Open
Conversation
Jetz72
reviewed
Mar 31, 2026
|
|
||
| /** Returns a runnable to start a match with the applied variants if allowed. */ | ||
| public Runnable startGame() { | ||
| FModel.getBlocks(); // Ensure blocks are loaded for Momir Basic and MoJhoSto deck generation |
Contributor
There was a problem hiding this comment.
I'm not sure if this is the most appropriate place to apply this workaround, or if it's the most appropriate workaround. Anyone else have any thoughts on this, @Hanmac, @tool4ever?
Contributor
There was a problem hiding this comment.
Seems this got broken by #8750, so thanks for the find
imo just needs to be refactored to have getBlockLands() lazy initialize itself
Author
There was a problem hiding this comment.
It's tricky because neither FModel nor CardBlock are accessible from GameType or StaticData, but I could move it inside this block so it's only loaded when the deck needs to be autogenerated
else if (autoGenerateVariant != null) {
Sorry I'm not really familiar with the codebase yet
clairchiara
force-pushed
the
feature/momir-random-land-art
branch
from
efa38fd to
ecff5e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug with Momir always using land art from the last set to generate the deck
+
make the lands more randomised and not all from the same set